Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure karpenter and velero resources are not created when they are not enabled #149

Merged
merged 3 commits into from
May 1, 2023
Merged

fix: Ensure karpenter and velero resources are not created when they are not enabled #149

merged 3 commits into from
May 1, 2023

Conversation

gohmc
Copy link
Contributor

@gohmc gohmc commented May 1, 2023

What does this PR do?

To resolve apply failed when not enable Karpenter and/or Velero.

Motivation

Create and use the data resource only when enable_karpenter is false.

Update Velero local variables to accept empty string when enable_velero is false.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Executed terraform plan with success using the test.

@gohmc gohmc requested a review from a team as a code owner May 1, 2023 11:39
bryantbiggs
bryantbiggs reviewed May 1, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs changed the title Fix apply failed when not enable Karpenter and/or Velero fix: Ensure karpenter and velero resources are not created when they are not enabled May 1, 2023
bryantbiggs
bryantbiggs approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fixes!

@bryantbiggs bryantbiggs merged commit e8c244d into aws-ia:main May 1, 2023
@gohmc gohmc deleted the fix/karpenter_velero branch May 2, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply failed when not enable Karpenter and/or Velero
2 participants
@gohmc @bryantbiggs